-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with ember-template-recast v5 #155
Comments
We can fix the error by changing this: codemod-cli/src/bin-support.js Lines 60 to 66 in 461e100
To: let templateRecastBinPath = path.join(
path.dirname(require.resolve('ember-template-recast/package'),
'lib',
'bin.js'
);
return execa(templateRecastBinPath, ', binOptions, {
stdio: 'inherit',
env: {
CODEMOD_CLI_ARGS: JSON.stringify(options),
},
}); |
Actually, I just figured out what you ran into here. Checkout my comment in |
We need to update ember-template-recast to v5, which seems to have some breaking changes. See #138
Making things worse, when running a codemod with
npx
within a project that already has v5 in itsnode_modules
, node will take this version instead, which breaks the codemod withCannot destructure property 'parse' of 'undefined' as it is undefined.
. (Same as the dependabot PR's CI failure: https://github.com/rwjblue/codemod-cli/pull/138/checks?check_run_id=1807589103#step:5:138)The text was updated successfully, but these errors were encountered: