Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stringified number in macro call #1149

Closed
wants to merge 1 commit into from
Closed

Remove stringified number in macro call #1149

wants to merge 1 commit into from

Conversation

jhpratt
Copy link
Contributor

@jhpratt jhpratt commented Sep 30, 2019

As the code is otherwise identical, we can use stringify! to generate this in the documentation.

As the code is otherwise identical, we can use `stringify!` to generate
this in the documentation.
@jebrosen
Copy link
Collaborator

This approach doesn't actually work (and I think is part of the motivation for the horrifying-yet-charming docify! macro used elsewhere in the crate).

@jhpratt
Copy link
Contributor Author

jhpratt commented Sep 30, 2019

Hmm...you're right. I naïvely assumed that stringify! was eagerly evaluated.

@jhpratt jhpratt closed this Sep 30, 2019
@jhpratt
Copy link
Contributor Author

jhpratt commented Sep 30, 2019

Upsteam: rust-lang/rust#52607

@jhpratt jhpratt deleted the remove-duplicate-code branch December 10, 2019 22:50
@SergioBenitez SergioBenitez added the pr: closed This pull request was not merged label Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: closed This pull request was not merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants