Remove crate_visiblity_modifier feature gate, others that are unused
#1060
Conversation
- Use hyper's MakeService implementation with futures API - Use tokio runtime to serve HTTP backend
Minimum rustc bump required for rust-lang/rust#61775
This lets us keep support for keep-alive and remote address while doing other work on async, at the cost of TLS. Abstracting over the connection type will be done more thoroughly later.
This requires some awkward channel and spawning work because Body might contain borrowed data.
Adds body_string_wait and body_bytes_wait functions to LocalRequest for convenience.
This is required to be able to do anything useful with the body in the outgoing response. Request fairings do not appear to need to be async as everything on Data that returns a future moves self and on_request only gets &Data, but the same change in this commit should work for on_request if desired.
Like with response fairings, this is required to be able to do anything useful with the body.
Also update 'static_files' example.
…ely match the pre-async code.
Other features are not used in places, namely `doc_cfg`, `proc_macro_span`, and `label_break_value`.
jhpratt
changed the title
crate_visiblity_modifier feature gate, others that are unused
|
This will likely be done after merging |
|
Can you rebase this on master? Also, we should consider which of these can be made |
|
I'm going to close this since it's now rather outdated. I would love a PR for this that takes into account #1060 (comment), however. Please let me know if you intend to work on it as I'll likely get to it myself sooner than later. |
|
I can certainly get around to it if you'd like. My intent was to wait to see if there will be any action on rust-lang/rust#53120, which could possibly have a PR land before a 0.5 release. Perhaps @Centril (or someone else) could kickstart that? Otherwise I can certainly go through and see what the minimum change would be. |
|
Side note: I believe I had expressed a preference toward doing this only after |
|
@jhpratt realistically I probably don't have the time to get to |
|
Alright, no problem! I'll see what I can do with regard to removing this feature gate later today. |
Simple change from
cratetopub(crate)where necessary. I've also removed other feature gates that were completely unused.Related: #19