Add option to disable binary symlink #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can rebase this PR? |
|
@nathantypanski could you please solve conflicts? Otherwise, we will have to close this PR :( |
|
@pkuczynski sure, looking into it now. |
Symlinks are already disabled for user installs. For cases where multiple system-wide Ruby versions are provided by RVM, add an option to disable symlinking of binaries to the system path. Default `rvm1_symlink` to `true` to maintain existing behavior parity.
nathantypanski
force-pushed
the
feature/disable-symlink
branch
from
647a93f to
327530e
Compare
|
@pkuczynski updated by rebasing against |
|
@thbar what you think? |
|
@pkuczynski I have no familiarity with this option at all (I also do not use root installation). I will have a closer look next week, but if someone is more familiar with that, another pair of eyes is welcome! |
sfgeorge
approved these changes
Mar 26, 2022
|
This sounds reasonable. Reading the code I wondered a bit of the precedence of operators ( |
pkuczynski
approved these changes
Mar 26, 2022
pkuczynski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlinks are already disabled for user installs. For cases where
multiple system-wide Ruby versions are provided by RVM, add an option to
disable symlinking of binaries to the system path.
Default
rvm1_symlinktotrueto maintain existing behavior parity.