Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RHEL 7 & 8 based distros to work around /tmp execution issues #230

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

stevenhaddox
Copy link
Contributor

@stevenhaddox stevenhaddox commented Nov 23, 2021

Implements the suggested fix from #155 in order to enable rvm to install properly on CentOS 8 (and hopefully 7 and a few other distro variations as well).

Fixes #155

@stevenhaddox stevenhaddox requested a review from a team as a code owner November 23, 2021 03:21
@stevenhaddox
Copy link
Contributor Author

Shout out to @coofercat for the suggested fix.

danochoa
danochoa previously approved these changes Nov 23, 2021
Copy link
Contributor

@danochoa danochoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nartz
Copy link

nartz commented Jan 26, 2022

I could use this as well - thanks!

@stevenhaddox
Copy link
Contributor Author

Thought I'd follow-up on this to see if it might be able to be merged (I came across my #TODO in my galaxy file preventing me from being able to enable the galaxy collection for rvm until this is merged in).
cc @danochoa, maybe?

tasks/rvm.yml Outdated Show resolved Hide resolved
@stevenhaddox
Copy link
Contributor Author

@sfgeorge @danochoa - pushed up the requested change. Let me know if you need anything else and thanks for your time.

@sfgeorge
Copy link
Contributor

sfgeorge commented Mar 1, 2022

@stevenhaddox Fantastic, thank you for the quick change. I'm terribly sorry to ping-pong with another request, but could you add a brief entry in CHANGELOG.md? Just a bullet would about fixing installation error in CentOS 7&8 would do.

@stevenhaddox
Copy link
Contributor Author

@sfgeorge no need to apologize. Thanks for your patience. Hopefully that last push is what you're looking for 🤞🏻

@sfgeorge
Copy link
Contributor

sfgeorge commented Mar 1, 2022

I shall bother you no more, this hungry commit-monster is finally satiated!

Thank you for the great fix, @stevenhaddox !

@sfgeorge
Copy link
Contributor

sfgeorge commented Mar 1, 2022

Oops, I don't have ability to move this forward. @danochoa Can you merge if you deem it ready?

@danochoa
Copy link
Contributor

danochoa commented Mar 1, 2022

It looks like the old CI server is no longer working. Maybe @pkuczynski can help? I think I don't have access to fix this but I can poke around a bit later. https://travis-ci.org/github/rvm/rvm1-ansible/requests

@sfgeorge
Copy link
Contributor

sfgeorge commented Mar 2, 2022

@danochoa I noticed the same and tracking as #233.

tl;dr With new pricing changes, it's possible but semi-painful to get a renewal of some Travis-CI build hours going. Alternatively, we can move to GitHub Actions.

@pkuczynski pkuczynski changed the title Fixes rvm/rvm1-ansible#155 Fix RHEL 7 & 8 based distros to work around /tmp execution issues Mar 25, 2022
@pkuczynski pkuczynski merged commit 0fcf5f3 into rvm:master Mar 25, 2022
@pkuczynski
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files in /tmp Cannot be Executed in Centos 7
5 participants