update tasks/rubies.yml - fix bool misuse

[danochoa]

This fixes issues introduced by deb1d3e as described by #209. The linked commit resolved warnings about bare variables in conditionals, but ended up breaking the conditional logic by misusing the bool filter. The bool filter returns true for vars set to ‘yes’, ‘on’, ‘1’, and ‘true’, and returns false otherwise, see https://docs.ansible.com/ansible/latest/user_guide/playbooks_conditionals.html.

[pkuczynski]

@lpaulmp what you think?

[pkuczynski]

@danochoa could you please solve the conflicts?

[danochoa]

@pkuczynski hold on, looks like I added a change that's not supposed to be in here

[danochoa]

@pkuczynski should be good to go

[pkuczynski]

Cool, thanks! One more question: in other places we are using is defined - wouldn't it be better here too? At least for consistency reasons...

[danochoa]

Probably a good idea. Updated for consistency. Thanks.

[thbar]

The PR works, but does not report changes. Also error handling on the detection (existing before the PR) is problematic and could fail silently.

I have suggested changes.

@danochoa let me know if this is acceptable for you!

[pkuczynski]

@thbar is it good to go now?

[pkuczynski]

@danochoa could you also add an entry in the CHANGELOG, please?

[thbar]

Much thanks to @danochoa for this work.

I have tested on a client installation. Deletion works when requested, reports changes, and will not fail if the ruby version is already deleted.

Looks perfect to me!

[thbar]

@pkuczynski I just approved, I believe it's in good shape for merging!

In the future (I see that there is work ongoing on the testing infrastructure at #215), we will likely be able to add a test case for that, to ensure it doesn't regress.

Poke @rvm/ansible, ready to merge, but unsure who can do that at the moment (without the Travis build passing?)

[gildegoma]

@thbar Once #215 is merged, this PR (and many others) should no longer fail (the Travis CI failure reason is that the build tries to install latest Bundler version on Ruby 2.2, but Bundler 2.0+ requires Ruby >= 2.3)

[thbar]

@pkuczynski can you force merge this one (I can't on my side)? It is ready and having it into master would be useful immediately to a number of people (I will also close related issues afterwards).

[pkuczynski]

Sure! Done!