Fix incorrect bool casts #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rien could you resolve conflicts in this PR please? |
|
I think this was already fixed by #207 (hence the merge conflicts). |
|
OK, cool, I wasn't sure which solution is correct. Thanks for replying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation fix (deb1d3e) uses
<variable> | boolto check whether a list was non-empty or a variable was defined. However, theboolfilter just tries to cast its input to a boolean and string values becomefalse.This PR fixes the intended behaviour by checking if variables are defined and lists are non-empty.