Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ruyi config datetimes timezone-aware #251

Merged
merged 6 commits into from
Dec 28, 2024

Conversation

xen0n
Copy link
Collaborator

@xen0n xen0n commented Dec 28, 2024

  • ensure ruyi-recorded config datetimes are timezone-aware
  • make ruyi telemetry consent write the consent time including the current local time zone

@xen0n xen0n added the refactor label Dec 28, 2024
@xen0n xen0n added this to the 0.25 milestone Dec 28, 2024
@xen0n xen0n force-pushed the timezone-awareness branch from 9867edc to 37dd900 Compare December 28, 2024 09:42
@xen0n xen0n force-pushed the timezone-awareness branch from 37dd900 to 4c7ff9c Compare December 28, 2024 09:43
…ted Python versions

Notably:

* datetime.datetime.isoformat() does not emit "Z" for UTC;
* datetime.datetime.fromisoformat() did not support ISO formats not
  emitted by isoformat() until Python 3.11.
@xen0n xen0n changed the title Make ruyi timezone-aware Make ruyi config datetimes timezone-aware Dec 28, 2024
@xen0n xen0n merged commit 3b0789c into ruyisdk:main Dec 28, 2024
11 checks passed
@xen0n xen0n deleted the timezone-awareness branch December 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant