m_boot_count was uint16 should be uint32 and comments #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already deleted from master
Only functional change it correction of m_boot_count from uint16 to uint32 and corresponding sizeof(m_boot_count) NOT sizeof(uint32).
Fortunately the loader added fill bytes after m_boot_count otherwise read_boot_count rt_flash_load would have clobbered memory after m_boot_count.
WAS .bss.m_boot_count
0x0000000020003840 0x2 _build/nrf52832_xxaa/app_log.c.o
*fill* 0x0000000020003842 0x6
Change log message to use X not d
Use TESTABLE_STATIC
Add many comments
Checked astyle , build and executed.
|
Can one of the admins verify this patch? |
Opps copy/paste error
|
ok to test |
|
What is the purpose of |
Good catch, thanks |
|
Sonar error is caused by external origin, it can be ignored here |
|
Comment lines like: Are for ease of picking out functions while scrolling though . notice spaces where name is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only functional change is correction of m_boot_count from uint16 to uint32 and corresponding sizeof(m_boot_count) NOT sizeof(uint32).
Fortunately the loader added fill bytes after m_boot_count otherwise read_boot_count rt_flash_load would have clobbered memory after m_boot_count.
WAS
Change log message for store_block: to use %X not %d
Use TESTABLE_STATIC
MInor LOG changes
Add many comments
Checked astyle , build and executed.