Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing duplicate BLE payload max length declarations #259

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Removing duplicate BLE payload max length declarations #259

merged 4 commits into from
Jul 24, 2024

Conversation

TheSomeMan
Copy link
Collaborator

No description provided.

@TheSomeMan TheSomeMan requested a review from ojousima November 17, 2023 02:30
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

ojousima
ojousima previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@ojousima ojousima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

src/interfaces/communication/ruuvi_interface_communication.h Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@TheSomeMan TheSomeMan requested a review from ojousima January 31, 2024 14:26
ojousima
ojousima reviewed Jan 31, 2024
View reviewed changes
src/nrf5_sdk15_platform/communication/ruuvi_nrf5_sdk15_communication_ble_advertising.c
// Other than 1 MBit / s require extended advertising.
if (BLE_GAP_PHY_1MBPS == scan_phys)
{
scan_params.extended = 0;
scan_params.extended = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this tested on hardware? I was under impression that 2 MBit/s extended advertisements send a primary advertisement at 1 MBit / s and primary advertisement contains information about when and where the actual extended payload will be.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this when implementing extended payload support on Gateway, but I agree that it looks suspicious. Let me test it again. I will tell you the result tomorrow.

@ojousima ojousima merged commit b1c999a into master Jul 24, 2024
5 checks passed
@TheSomeMan TheSomeMan deleted the ble_ext_payload_len branch October 4, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojousima ojousima ojousima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheSomeMan @ojousima