Resolves conversation is None exception (Netflix#3071)

rutvijmehta-harness · Mar 17, 2023 · 71f319c · 71f319c
1 parent 96b683b
commit 71f319c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/dispatch/plugins/dispatch_slack/case/messages.py b/src/dispatch/plugins/dispatch_slack/case/messages.py
@@ -122,7 +122,7 @@ def create_case_message(case: Case, channel_id: str):
     return Message(blocks=blocks).build()["blocks"]
 
 
-def create_signal_messages(case: Case) -> List[Message]:
+def create_signal_messages(case: Case, channel_id: str) -> List[Message]:
     """Creates the signal instance message."""
     messages = []
 
@@ -132,7 +132,7 @@ def create_signal_messages(case: Case) -> List[Message]:
             organization_slug=case.project.organization.slug,
             id=str(instance.id),
             project_id=case.project.id,
-            channel_id=case.conversation.channel_id,
+            channel_id=channel_id,
         ).json()
 
         signal_metadata_blocks = [

diff --git a/src/dispatch/plugins/dispatch_slack/plugin.py b/src/dispatch/plugins/dispatch_slack/plugin.py
@@ -88,7 +88,7 @@ def create_threaded(self, case: Case, conversation_id: str):
             ts=response["timestamp"],
         )
         if case.signal_instances:
-            messages = create_signal_messages(case=case)
+            messages = create_signal_messages(case=case, channel_id=conversation_id)
             for m in messages:
                 send_message(
                     client=client,