Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolt7: delay considering a channel edge deleted for 12-blocks #61

Conversation

vincenzopalazzo
Copy link
Collaborator

Fixes #60

Implementation proposal: lightning/bolts#1004

Changelog-Added: gossip: delay considering a channel edge deleted for 12-blocks proposed by lightning/bolts#1004

Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com

@vincenzopalazzo vincenzopalazzo added the SPEC Related to lightning network specification label Sep 19, 2022
@vincenzopalazzo vincenzopalazzo added the SPEC: BOLT 7 gossip Spec related to BOLT 7 gossip label Sep 19, 2022
Copy link
Owner

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 308e942

Looks exactly right. BOLT quote should be updated though?

@vincenzopalazzo vincenzopalazzo marked this pull request as ready for review September 20, 2022 13:16
Changelog-Added: gossip: delay considering a channel edge deleted for
12-blocks propose by lightning/bolts#1004

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo force-pushed the macros/bolt-forget-channel branch from 308e942 to c911a65 Compare September 20, 2022 18:24
Copy link
Collaborator Author

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c911a65

@vincenzopalazzo vincenzopalazzo merged commit 265bac0 into rustyrussell:master Sep 20, 2022
@vincenzopalazzo vincenzopalazzo deleted the macros/bolt-forget-channel branch September 20, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SPEC: BOLT 7 gossip Spec related to BOLT 7 gossip SPEC Related to lightning network specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gossip failure on cln with the new version of the protocol
2 participants