Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for 'fundchannel_start' crash on deconnection #6

Closed
wants to merge 9 commits into from
Closed

Add a test for 'fundchannel_start' crash on deconnection #6

wants to merge 9 commits into from

Commits on Aug 9, 2019

  1. Added possibility to configure max_concurrent_htlcs value for our cha… 

    …nnels. Eclaire has a default of 30 and I thought why not going with their value and while doing so make it configureable.
    @renepickhardt @rustyrussell
    renepickhardt authored and rustyrussell committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    8e7428d View commit details
    Browse the repository at this point in the history

  2. doc: Document max-concurrent-htlcs option.

    @renepickhardt @rustyrussell
    renepickhardt authored and rustyrussell committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    1dd8908 View commit details
    Browse the repository at this point in the history

  3. included feedback by Rusty to check the max_concurrent_htlc value for… 

    … both peers of a channel
    @renepickhardt @rustyrussell
    renepickhardt authored and rustyrussell committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    dfac1d1 View commit details
    Browse the repository at this point in the history

  4. pytest: enable deprecated APIs for multi-arg closes. 

    We're about to change the API, so this makes the tests still work
across the transition (and, as a bonus, tests our backwards compat
shim).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    b35dc46 View commit details
    Browse the repository at this point in the history

  5. close: change to a unilateraltimeout argument. 

    `close` takes two optional arguments: `force` and `timeout`.
`timeout` doesn't timeout the close (there's no way to do that), just
the JSON call.  `force` (default `false`) if set, means we unilaterally
close at the timeout, instead of just failing.

Timing out JSON calls is generally deprecated: that's the job of the
client.  And the semantics of this are confusing, even to me!  A
better API is a timeout which, if non-zero, is the time at which we
give up and unilaterally close.

The transition code is awkward, but we'll manage for the three
releases until we can remove it.

The new defaults are to unilaterally close after 48 hours.

Fixes: ElementsProject#2791
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    83e654a View commit details
    Browse the repository at this point in the history

  6. pytest: don't use deprecated options for close() in tests. 

    Only downside is you have to wait 1 second at least before
unilaterally closing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    0edc0ae View commit details
    Browse the repository at this point in the history

  7. gossipd: check that we don't try to access a deleted gossip entry. 

    We ignored this before, which meant that the DEVELOPER-mode check that we
delete the correct record didn't check that it wasn't already deleted.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    f9ecc76 View commit details
    Browse the repository at this point in the history

  8. lightningd: fix crash when peer disconnects after fundchannel_start, … 

    …before cancel/complete

Fixes: ElementsProject#2831
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell @cdecker
    rustyrussell authored and cdecker committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    710d015 View commit details
    Browse the repository at this point in the history

  9. Add a test for 'fundchannel_start' crash on deconnection

    @darosior
    darosior committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    cd32da6 View commit details
    Browse the repository at this point in the history