Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: wasm_opt, chromedriver & geckodriver version #926

Closed
wants to merge 5 commits into from

Conversation

meck93
Copy link

@meck93 meck93 commented Oct 19, 2020

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

Description

Fixes the issue reported in #919

@meck93 meck93 changed the title update: wasm_opt + chromedriver version installation + release build: bump wasm_opt + chromedriver version Oct 19, 2020
@lucashorward
Copy link
Contributor

Seems good, but the download urls have changed (since the binaries in the release have a different naming convention now, it seems - https://github.com/WebAssembly/binaryen/releases), so if you could rename those accordingly, that would be great!

@meck93
Copy link
Author

meck93 commented Oct 23, 2020

Hi @lucashorward, thanks for the reply and feedback!
Maybe I don't fully understand what you mean. Could you be a bit more specific?

The download URL for binaryen version_97 looks like this: https://github.com/WebAssembly/binaryen/releases/download/version_97/binaryen-version_97-x86_64-linux.tar.gz

And, this is the way that we already compose it:

Ok(format!(
    "https://github.com/WebAssembly/binaryen/releases/download/{vers}/binaryen-{vers}-{target}.tar.gz",
    vers = "version_97",
    target = target,
))

Or, did you mean something different?

@lucashorward
Copy link
Contributor

Yes, that is the url I mean, and I see you've correctly updated the target variable that's used in that link for linux (which has changed from x86-linux to x86_64-linux- in src/install/mod.rs line 167), but the path has also changed for windows and macos in this newer release of wasm_opt. So those paths should be updated here as well:
For 64-bit macos, it should go from x86_64-apple-darwin to x86_64-macos (line 176)
For 64-bit windows, it should go from x86-windows to x86_64-windows (line 179)

The failing CI test is because of this, the url for linux is correct but for the other systems a 404 is returned.

On top of that, I see there are no 32-bit versions listed - not sure what the impact of that will be to be honest. Maybe @ashleygwilliams has an idea on that. On the one hand, we don't want to keep using this older version, but I'm unsure if this will break all 32-bit builds.

@meck93
Copy link
Author

meck93 commented Oct 24, 2020

Thanks a lot for the clarification! That makes a lot of sense. I'm on Linux and that's probably why I only updated the Linux URL when I compiled wasm-pack locally (before opening the PR). But I'll fix the other ones as well!

@meck93 meck93 force-pushed the fix/wasm_opt_version branch from 19fa624 to 4cadad3 Compare October 26, 2020 05:55
@meck93 meck93 changed the title installation + release build: bump wasm_opt + chromedriver version bump wasm_opt, chromedriver & geckodriver version Oct 26, 2020
@meck93 meck93 changed the title bump wasm_opt, chromedriver & geckodriver version bump: wasm_opt, chromedriver & geckodriver version Oct 26, 2020
@drager
Copy link
Member

drager commented May 30, 2023

Already fixed in new releases.

@drager drager closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants