-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: wasm_opt, chromedriver & geckodriver version #926
Conversation
Seems good, but the download urls have changed (since the binaries in the release have a different naming convention now, it seems - https://github.com/WebAssembly/binaryen/releases), so if you could rename those accordingly, that would be great! |
Hi @lucashorward, thanks for the reply and feedback! The download URL for binaryen version_97 looks like this: https://github.com/WebAssembly/binaryen/releases/download/version_97/binaryen-version_97-x86_64-linux.tar.gz And, this is the way that we already compose it: Ok(format!(
"https://github.com/WebAssembly/binaryen/releases/download/{vers}/binaryen-{vers}-{target}.tar.gz",
vers = "version_97",
target = target,
)) Or, did you mean something different? |
Yes, that is the url I mean, and I see you've correctly updated the target variable that's used in that link for linux (which has changed from The failing CI test is because of this, the url for linux is correct but for the other systems a 404 is returned. On top of that, I see there are no 32-bit versions listed - not sure what the impact of that will be to be honest. Maybe @ashleygwilliams has an idea on that. On the one hand, we don't want to keep using this older version, but I'm unsure if this will break all 32-bit builds. |
Thanks a lot for the clarification! That makes a lot of sense. I'm on Linux and that's probably why I only updated the Linux URL when I compiled |
19fa624
to
4cadad3
Compare
Already fixed in new releases. |
Make sure these boxes are checked! 📦✅
rustfmt
installedcargo fmt
on the code base before submittingDescription
Fixes the issue reported in #919