Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when wasm32-unknown-unknown is missing #602

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

drager
Copy link
Member

@drager drager commented Mar 23, 2019

A work in progress to resolve #579.

@ashleygwilliams ashleygwilliams added this to the 0.8.0 milestone Mar 23, 2019
@ashleygwilliams ashleygwilliams added the work in progress do not merge! label Mar 23, 2019
@drager drager force-pushed the improve-error-message branch 4 times, most recently from 9736ea8 to 2696862 Compare March 24, 2019 19:18
@drager
Copy link
Member Author

drager commented Mar 24, 2019

Would appreciate review from you @ashleygwilliams and @alexcrichton. I put the docs under "Prerequisites" but since it became pretty long I think it should maybe be in it's own section. What do you guys think?

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits on organization. can take a look at the code a bit more closely later when it's not the weekend and i've had a beer or two ;)

docs/src/prerequisites/index.md Outdated Show resolved Hide resolved
src/build.rs Outdated Show resolved Hide resolved
doc: Write about adding wasm32-unknown-unknown manually
@drager drager force-pushed the improve-error-message branch from 2696862 to 12fcdad Compare March 27, 2019 20:35
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on this, thanks so much!

@ashleygwilliams ashleygwilliams changed the title [WIP] Improve error message when wasm32-unknown-unknown is missing Improve error message when wasm32-unknown-unknown is missing Mar 29, 2019
@ashleygwilliams ashleygwilliams merged commit 2947414 into rustwasm:master Mar 29, 2019
@gotcha
Copy link

gotcha commented Apr 1, 2019

@drager @ashleygwilliams I am impressed by the level of attention to details and usability ! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error for missing wasm32-unknown-unknown on non-rustup environments can be improved
4 participants