Generate self-.gitignore as part of pkg folder #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RReverser thanks so much for this and so sorry for the delay in reviewing! could you add a small blurb in the documentation and/or README to explain that this directory is now ignored by default? we may need to wait on landing this til i implement a way to edit package.json and add js or other assets to the pkg, but i imagine that should be for the release directly after the next one (which is happening this week) |
ashleygwilliams
approved these changes
Dec 27, 2018
|
Thanks! Sorry - as mentioned in the other thread, I initially sent this from a different laptop and then with holidays and getting sick didn't get around to finishing this. |
|
it's all good, no worries at all <3 thanks for you efforts! |
ashleygwilliams
added
changelog - feature
and removed
needs docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion with @ashleygwilliams in https://twitter.com/ag_dubs/status/1068173944807727110,
pkgshould be commonly ignored, and the simplest way to do that is to just generate nested.gitignoreinside it ignoring everything (including.gitignoreitself).Make sure these boxes are checked! 📦✅
rustfmtinstalled and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightlyrustfmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨