Don't require cdylib crate-type for testing #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cdylib` crate type output isn't actually necessary for the `wasm-pack test` stage because `wasm-bindgen` isn't run over a wasm file. This commit removes the checks during `wasm-pack test` that the `cdylib` crate type is configured.
fitzgen
approved these changes
Nov 7, 2018
|
I just came here to open this issue since it was preventing me from migrating to wasm-pack test... sweet! Will wait for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cdylibcrate type output isn't actually necessary for thewasm-pack teststage becausewasm-bindgenisn't run over a wasmfile. This commit removes the checks during
wasm-pack testthat thecdylibcrate type is configured.