Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manifest/npm): set correct sideEffects for bundler target #1237

Closed
wants to merge 1 commit into from
Closed

fix(manifest/npm): set correct sideEffects for bundler target #1237

wants to merge 1 commit into from

Conversation

Menci
Copy link

@Menci Menci commented Feb 26, 2023

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Fix #1235. Set sideEffects to the entry file for bundler target while keep false for web target.

@Liamolucko
Copy link
Contributor

#1224 already does the same thing as this PR.

@Menci Menci mentioned this pull request Mar 14, 2023
Closed
@drager
Copy link
Member

drager commented May 30, 2023

Closing in favor of #1224

@drager drager closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sideEffects should not be false now
3 participants
@Menci @Liamolucko @drager