Fixed webidl output formatting on Windows #4335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the reason formatting the output files from
webidl
didn't work on Windows. Therustfmt
command was invoked with all files given as command arguments. On Windows, there's a 32k character limit to command strings, so it failed to execute the command, because it was too long.My solution was to invoke the command multiple times with 400 files each. In my testing ~840 files was the limit, but since the command length obviously depends on the file names, I gave us a lot of breathing room by picking 400.
I also removed the note about formatting failing, since it isn't relevant anymore. I'll also make another PR to address the newline issue.