Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebGPU API to draft 2024-11-22 #4290

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

nolanderc
Copy link
Contributor

Needed for gfx-rs/wgpu#6614

@nolanderc nolanderc force-pushed the webgpu-2024-11-22 branch 2 times, most recently from efa902f to f16e3bb Compare November 28, 2024 15:14
@nolanderc
Copy link
Contributor Author

I don't know why one of the CI checks just failed (CI / test_examples (pull_request)). It worked before I rebased, and seems to work in the latest commit before that. Not sure if that test is reliable?

@nolanderc
Copy link
Contributor Author

Just pushed the same commit again, and now it works. Definitely a flaky test.

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits that I will push myself, otherwise LGTM.
Thank you!

crates/webidl/src/generator.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@daxpedda daxpedda merged commit a955368 into rustwasm:main Nov 28, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants