Restrict to bumpalo v3.12.1 #3997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last version of bumpalo that compiles with wasm-bindgen's stated MSRV of v1.57. Signed-off-by: John Nunley <dev@notgull.net>
|
I do understand where this is coming from and it affected crates I maintain myself and with others (Winit) as well, but I don't think its an option to limit the dependency for users who don't require the MSRV. Unfortunately I'm not aware of any good fix for this except to wait for rust-lang/cargo#9930, which obviously wouldn't solve this issue because it would only affect future Rust versions. Let me know if you know a better way of handling this. I'm also open to debate the issue if you think I'm missing something here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last version of bumpalo that compiles with wasm-bindgen's
stated MSRV of v1.57.