Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timers to work in workers too. #106

Merged
merged 4 commits into from
Jan 18, 2020
Merged

Fix timers to work in workers too. #106

merged 4 commits into from
Jan 18, 2020

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jan 3, 2020 •
edited
Loading

This has been fixed before in a different way by #56.
But was removed again by #103 to solve #96.

I think the solution offered in this PR should solve #96 without breaking the fix provided by #103.

Related: rustwasm/wasm-bindgen#1046.

@daxpedda daxpedda mentioned this pull request Jan 4, 2020
Merged
@daxpedda daxpedda closed this Jan 12, 2020
@daxpedda daxpedda reopened this Jan 12, 2020
Pauan
Pauan suggested changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay.

I've left a couple comments on some changes I'd like to see.

crates/timers/src/callback.rs Outdated Show resolved Hide resolved
crates/timers/src/callback.rs Outdated Show resolved Hide resolved
Pauan
Pauan approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your work!

@Pauan Pauan merged commit f9b1727 into rustwasm:master Jan 18, 2020
@chemicstry chemicstry mentioned this pull request Oct 19, 2020
Merged
@teohhanhui teohhanhui mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekdreery derekdreery derekdreery left review comments

@Pauan Pauan Pauan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxpedda @Pauan @derekdreery