v0.12.0: update to rustls 0.22, address breaking changes #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
force-pushed
the
cpu-0.22-prep
branch
4 times, most recently
from
65135f7 to
38ca774
Compare
cpu
changed the title
cpu
changed the title
|
|
This looks good to me so far. |
It hasn't been used since the 0.22 preparation work that tracked upstream changes w.r.t. scts in-handshake.
Now that 0.22 has been published we can directly link to the upstream client/server cert verifier builder types.
* Rustls 0.22.0-alpha-6 -> 0.22.0
* Webpki 0.102.0-alpha.8 -> 0.102.0
* Rustls pki-types 0.2.3 -> 1.0
* `CryptoProvider` is now a struct.
* `rustls::crypto::ring::RING` is now
`rustls::crypto::ring::default_provider`.
* `WebPkiServerVerifier`'s default fns are removed,
`rustls::crypto::{verify_tls12_signature|verify_tls13_signature}` and
`rustls::crypto::WebPkiSupportedAlgorithms.supported_schemes` can be
used instead.
* `rustls::Error::Other` now holds `rustls::OtherError` variant instead
of `Arc<...>`.
cpu
changed the title
|
I believe this branch is ready, and we could merge it and publish 0.12.0. Alternatively, I'm almost done with a first draft for broader crypto provider support. We could also hold off on publishing 0.12.0 until that work is ready. |
jsha
approved these changes
Dec 3, 2023
Sure, sounds good to me 👍
I'd like to update the CHANGELOG first. I'll try to put a PR up for that shortly. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates rustls-ffi to use rustls 0.22. This branch retains ring as the only supported crypto provider. Subsequent work will allow selection of ring or aws_lc_rs as well as mixing/matching.
CryptoProvideris now a struct.rustls::crypto::ring::RINGis nowrustls::crypto::ring::default_provider.WebPkiServerVerifier's default fns are removed,rustls::crypto::{verify_tls12_signature|verify_tls13_signature}andrustls::crypto::WebPkiSupportedAlgorithms.supported_schemescan be used instead.rustls::Error::Othernow holdsrustls::OtherErrorvariant instead ofArc<...>.