Skip to content

Conversation

iamjpotts
Copy link
Contributor

Enable nightly formatting option group_imports = "StdExternalCrate".

#379 (comment)

@iamjpotts
Copy link
Contributor Author

It is not clear to me why the github ui is expecting a Format & clippy job. That job was split into two - a Clippy job and a Format (unstable) job.

@iamjpotts iamjpotts force-pushed the jp/cargo-fmt-group-imports branch 2 times, most recently from a8a15c5 to 251bb2d Compare September 28, 2025 17:50
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iamjpotts iamjpotts force-pushed the jp/cargo-fmt-group-imports branch from 251bb2d to 96355f6 Compare October 1, 2025 01:22
@iamjpotts
Copy link
Contributor Author

If #379 is merged first, this will need a rebase and another cargo fmt run applied to it.

@djc djc requested a review from est31 October 1, 2025 08:35
@iamjpotts iamjpotts force-pushed the jp/cargo-fmt-group-imports branch from 96355f6 to 4a9889a Compare October 7, 2025 00:26
@iamjpotts
Copy link
Contributor Author

Rebased to include yesterday's changes to main.

@iamjpotts iamjpotts force-pushed the jp/cargo-fmt-group-imports branch 2 times, most recently from b86ad4c to 91376b3 Compare October 7, 2025 00:36
Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
@iamjpotts iamjpotts force-pushed the jp/cargo-fmt-group-imports branch from 91376b3 to 68fff8d Compare October 7, 2025 00:39
@djc
Copy link
Member

djc commented Oct 7, 2025

@est31 did you want to take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants