refactor: Generalize csr/crl signed_by to take &impl AsRef issuer #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes these consistent with Certificate::signed_by.
djc
approved these changes
Jan 19, 2025
| @@ -157,7 +157,7 @@ impl CertificateParams { | |||
| pub fn signed_by( | |||
| self, | |||
| public_key: &impl PublicKeyData, | |||
| issuer: &impl AsRef<Self>, | |||
| issuer: &impl AsRef<CertificateParams>, | |||
There was a problem hiding this comment.
Hmm, I tried to make an explanation of this change in the PR summary.
There was a problem hiding this comment.
The argument you made seems reasonable to me in absence of a reason to prefer keeping it as-is.
est31
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #307 by applying the same treatment to
csrandcrl.Also improves
CertificateParams::signed_byissuer fromAsRef<Self>toAsRef<CertificateParams>, because I think it's irrelevant that the issuer is the same type as the CertificateParams being signed, thusSelfshould not be used.