Fix warnings for non-snake case atom module names #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcksl
force-pushed
the
fix/nif-unit-enum-non-snake-case
branch
from
aef94c7 to
842aea7
Compare
bcksl
changed the title
|
LGTM. I think these are exactly the cases where such warnings are emitted. |
turion
approved these changes
Nov 13, 2023
philss
added a commit
that referenced
this pull request
Jan 5, 2024
This is related to #573, but now the macro is given a warning even with the annotation to ignore. So this is a fix that turns the atoms module name generated by the macro in a snake case name.
filmor
pushed a commit
that referenced
this pull request
Feb 13, 2024
This is related to #573, but now the macro is given a warning even with the annotation to ignore. So this is a fix that turns the atoms module name generated by the macro in a snake case name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.