Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for discovery server #2

Merged
merged 4 commits into from
Apr 27, 2017
Merged

Conversation

Logout22
Copy link
Contributor

I wrote a simple discovery server to avoid having to exchange IP addresses manually. It can be found here:

https://github.com/Logout22/crowdchat-rs-server

I would be happy to merge the server repo into the rustdresden project as well.

Thanks for reviewing!

@Logout22 Logout22 requested review from whimboo and hoodie April 24, 2017 04:47
@Logout22 Logout22 self-assigned this Apr 24, 2017
@whimboo
Copy link
Member

whimboo commented Apr 24, 2017

Hm, I'm not the perfect reviewer for the code yey, so I started to at least have a look in how to get it running. But building the binary via cargo run fails for me in two places (lines 34 and 40):

34 |         send_socket.send_to(wire_format.as_bytes(),addr).unwrap();
   |                     ^^^^^^^ the trait `std::net::ToSocketAddrs` is not implemented for `std::string::String`

@hoodie
Copy link
Member

hoodie commented Apr 24, 2017

that particular feature has landed in 1.16 of the standard library, so you're probably only one rustup update away from compiling 😁

https://github.com/rust-lang/rust/blob/master/RELEASES.md
rust-lang/rust#39048

@hoodie hoodie closed this Apr 27, 2017
@whimboo whimboo reopened this Apr 27, 2017
@hoodie hoodie merged commit e701442 into rustdresden:master Apr 27, 2017
@hoodie
Copy link
Member

hoodie commented Apr 27, 2017

sorry for the close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants