Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: implement -s #362

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewliebenow
Copy link
Contributor

Also: fix a couple small bugs

@andrewliebenow andrewliebenow force-pushed the diff-implement-dash-s branch 2 times, most recently from 19c601b to 2cb7315 Compare October 27, 2024 09:42
Copy link
Contributor

@jgarzik jgarzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review looks OK.

In regards to testing, does the -s output match BSD or Linux diff?

@andrewliebenow
Copy link
Contributor Author

Review looks OK.

In regards to testing, does the -s output match BSD or Linux diff?

I'm not sure what the difference is, and some searching didn't turn up anything useful. Could you briefly explain?

@jgarzik
Copy link
Contributor

jgarzik commented Nov 4, 2024

Review looks OK.
In regards to testing, does the -s output match BSD or Linux diff?

I'm not sure what the difference is, and some searching didn't turn up anything useful. Could you briefly explain?

Restated: When testing your change on BSD and Linux, does the posixutils diff w/ your change produce (a) similar or (b) different output from BSD diff -s and Linux diff -s?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants