-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macos with_disallow_hidpi
#821
Add macos with_disallow_hidpi
#821
Conversation
r? @francesca64 |
@slmjkdbtl Can you resolve the merge conflict? r? @mtak- |
@Osspial can you just merge this? It's been a week. |
Sorry it took so long to respond to this! I'm not sure I'm comfortable with exposing another platform-specific DPI override just for macOS. We've already got an override for X11, and I don't want to keep adding platform-specific ways of controlling winit's DPI support until we have several subtly different and incompatible ways to set DPI. There's talk going on in #796 about the HiDPI API, and I'd like to see that conclude before we decide whether or not to merge this. |
@Osspial What's the verdict? I'd rather this gets merged. |
Just to be sure I get a clear image, what would be the consequence of this flag precisely? |
To quote the macos docs:
Basically, if you disable this flag, the window's size on the screen will stay the same, but it's contents will get magnified. This is unlike changing the dpi, which changes the window's size. Maybe @slmjkdbtl can provide a screenshot? |
Ok, so This is the same as what a non-hidpi wayland app would do, so such a flag would be trivial to replicate on Wayland, and I guess it would only make sense on these platforms. |
@slmjkdbtl Could you quickly rebase this against the new master? |
FWIW, I'm going to rescind my objections to this. We could also implement this on Windows, but it would be an |
Hey, apologizes, but this PR has fallen greatly out of date. Could you rebase this against the new master and open a new PR. Anyways, I'm closing this one. Thanks. |
CHANGELOG.md
if knowledge of this change could be valuable to usersImplemented by gentz and tested myself on macOS, mimicing sdl's
SDL_WINDOW_ALLOW_HIGHDPI
flag