Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to image 0.20 #683

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Oct 22, 2018

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created an example program if it would help users understand this functionality

Tested on x11/kde and windows.
This should be merged before the release of 0.18.

@rukai
Copy link
Contributor Author

rukai commented Oct 23, 2018

Just noticed there was a warning triggered when building the example without the icon_loading feature, so I fixed that as well by moving the use winit::Icon into fn main() { }

@francesca64
Copy link
Member

Alright, awesome!

@francesca64 francesca64 merged commit da1d479 into rust-windowing:master Oct 24, 2018
@Osspial Osspial mentioned this pull request Feb 22, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants