Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.17.3 #679

Closed
wants to merge 1 commit into from
Closed

version 0.17.3 #679

wants to merge 1 commit into from

Conversation

sodiumjoe
Copy link
Contributor

  • [ ] Tested on all platforms changed
  • [ ] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • [ ] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • [ ] Created an example program if it would help users understand this functionality

@sodiumjoe sodiumjoe changed the title bump version version 0.17.3 Oct 20, 2018
@rukai
Copy link
Contributor

rukai commented Oct 20, 2018

I'm pretty sure we cant do a patch release because at least commit 5a0bc01 is a breaking change. Due to adding VirtualKeyCode enum variants.

However I would definitely like to see a release before events loop 2 PR is merged, because it will take a while to cleanup any bugs introduced (thus prolonging the next release) and it would be nice to upgrade winit versions more incrementally as events loop 2 will have a lot of breaking changes.
Whether we release 0.18 now or later I don't mind.

@sodiumjoe
Copy link
Contributor Author

I'm not really sure how winit handles semver, so I just opened #680 as well. I'll let @francesca64 go with whichever one is correct and close the other one 😄

@elinorbgr
Copy link
Contributor

Hmm, the changelog entry for #641 should have marked the change as breaking.

Winit has respected semver up to now, and I don't think there are plans for this changing, so the path forward 0.18.0.

@elinorbgr elinorbgr closed this Oct 20, 2018
@sodiumjoe sodiumjoe deleted the v0.17.3 branch October 20, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants