Implement common Std traits on many types #3796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested review from
jackpot51,
notgull,
kchibisov,
madsmtm and
MarijnS95
as code owners
daxpedda
force-pushed
the
more-derive
branch
3 times, most recently
from
b60f794 to
7b5c899
Compare
kchibisov
requested changes
Jul 20, 2024
kchibisov
approved these changes
Jul 20, 2024
notgull
approved these changes
Jul 20, 2024
| @@ -486,7 +492,7 @@ unsafe impl rwh_05::HasRawDisplayHandle for ActiveEventLoop { | |||
| /// | |||
| /// - A zero-sized type that is likely optimized out. | |||
| /// - A reference-counted pointer to the underlying type. | |||
| #[derive(Clone)] | |||
| #[derive(Clone, PartialEq, Eq)] | |||
There was a problem hiding this comment.
What's the user story for this one?
There was a problem hiding this comment.
Ha!
I would honestly not be able to come up with one.
Happy to remove it if you don't like it!
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable implementations:
DeviceId:Default, usesDeviceId::dumy().ActiveEventLoop,EventLoop,EventLoopProxy: refrained from implementing anymore thenDebugbecause they should be unique.EventLoopBuilder:Eq,HashandPartialEq.InnerSizeWriter: refrained from implementingHash.OwnedDisplayHandle:EqandPartialEq.KeyLocation,ModifiersKeyState:OrdandPartialOrd.AnyThread:Clone.Window:Eq,HashandPartialEqviaWindowId.Replaced
Debugimplementations usingf.pad("Type { .. }")withf.debug_struct("Type").finish_non_exhaustive().Let me know if anything is too contentious and I can remove it.
Follows C-COMMON-TRAITS.