Make EventLoopProxy Sync
#3449
Make EventLoopProxy Sync
#3449
Conversation
madsmtm
added
S - enhancement
|
Maybe we should push the |
I don't think it hurts to merge this in the meantime. |
tests/sync_object.rs
Outdated
| #[allow(dead_code)] | ||
| fn is_send<T: 'static + Send>() { | ||
| // ensures that `winit::EventLoopProxy` implements `Send` | ||
| needs_sync::<winit::event_loop::EventLoopProxy<T>>(); | ||
| } |
There was a problem hiding this comment.
This should just use needs_sync, because we test Send in other test.
There was a problem hiding this comment.
This doesn't test if EventLoopProxy implements Send, it tests if EventLoopProxy implement Sync if T is Send.
There was a problem hiding this comment.
But you can move the T: Send in the test itself?
There was a problem hiding this comment.
I don't think you can use generics on #[test]. It would be a compile error anyway so we don't actually need #[test] in the first place.
I think the way it's right now is just fine, but maybe adding a comment would help.
There was a problem hiding this comment.
Not sure what I should write as a comment, but I've made the exiting comment text a bit clearer
madsmtm
force-pushed
the
event-loop-proxy-sync
branch
from
d17b208
to
bc63612
Compare
Co-authored-by: daxpedda <daxpedda@gmail.com> Closes: #3448
kchibisov
force-pushed
the
event-loop-proxy-sync
branch
from
bc63612
to
3d23283
Compare
kchibisov
force-pushed
the
event-loop-proxy-sync
branch
from
3d23283
to
358d61c
Compare
Fixes #3448.
CHANGELOG.mdif knowledge of this change could be valuable to users