-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DWMWA_SYSTEMBACKDROP_TYPE support on Windows #3257
Conversation
@msiglreith would you mind taking a look? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm - unable to test it as I don't have Windows 11 installed, on older builds it returns an unsupported parameter error but doesn't cause any issues.
Keeping it on hold (similar to other PRs with backend specific extensions) as there is a larger API change planned for the next version #3367
I don't think you should block on that, we still need to do a lot more discussion before we're prepared to do the API rework. |
@msiglreith would you like for me to resolve merge conflicts? |
@Dubzer yes, please! |
# Conflicts: # src/platform/windows.rs # src/platform_impl/windows/mod.rs # src/platform_impl/windows/window.rs
Done |
@Dubzer since you tested this inside Alacritty, did you ever open a PR to enable it? Perhaps behind |
@MarijnS95 actually I didn't. I was waiting for the winit version to be updated and then I forgot lol. It should be pretty easy to add such a flag if you want to contribute it yourself. |
@Dubzer the plan is to back this platform extension out entirely "lol". There's an API-agnostic |
@MarijnS95 Sorry, I'm out of context and not really sure about the current plans for set_blur. Acrylic is similar to blur in that it shows what's behind the window on the z-axis. But it's still a different, more complex effect. Here's a breakdown of it from the design docs: And Mica doesn't show what's behind a window at all. It blends the desktop background into the window background: Given all these factors, I'm not sure how you want to integrate DWM SBD into the set_blur API without creating unexpected results for the user and keeping all the material selection options available |
CHANGELOG.md
if knowledge of this change could be valuable to usersWith this code, it will be possible to apply the Acrylic and the Mica backdrop material effect
Tested on Windows 11 build 22631.2715, using new API in the Alacritty source code.