Upgrade to ndk 0.8, ndk-sys 0.5 and android-activity 0.5 releases
#3145
Conversation
MarijnS95
requested review from
jackpot51,
msiglreith,
daxpedda,
madsmtm and
kchibisov
as code owners
Cargo.toml
Outdated
| ndk-sys = "0.5.0-beta.0" | ||
| # https://github.com/rust-mobile/android-activity/pull/128 | ||
| # android-activity = "0.5.0" | ||
| android-activity = { git = "https://github.com/MarijnS95/android-activity", rev = "720e5a3" } |
There was a problem hiding this comment.
Since we're using a git dependency, should this PR be marked as draft for now?
There was a problem hiding this comment.
Yeah, git dependencies are not allowed for stable releases.
There was a problem hiding this comment.
It is already marked as Depends on, and I'd rather push forward on getting a release out some time soon.
@rib if you can, the NDK crate is now ready and android-activity can go out of beta too.
There was a problem hiding this comment.
@MarijnS95 distributions don't package crates having git dependencies, even for non-native platforms. I can't do a release with the git dependencies.
Maybe sending email to @rib will work if they are missing.
There was a problem hiding this comment.
@kchibisov we are thinking and saying the same.
I'm just not the release manager for android-activity, and @rib doesn't seem to have the cargo publish step automated in the CI with a token in GitHub secrets so I won't be able publish a release in his name either way.
Regardless, it hasn't been 24h yet since I published the ndk and it's still weekend so I wouldn't call it missing, just unfortunate timing.
There was a problem hiding this comment.
Anyway, I've converted this PR to "draft" as that seems to be the main point of contention (...?).
There was a problem hiding this comment.
@kchibisov we are thinking and saying the same.
Ah, release out of android activity, not winit. I've opened an issue on their tracker. At least it seems like issues are being read quite often.
There was a problem hiding this comment.
I'm sure he's fully aware of the release schedule, just unfortunate timing on my end and it's quite a long trail (release raw-window-handle -> ndk(-sys), android-activity, winit, all owned and maintained by different people).
MarijnS95
changed the title
ndk(-sys) to stable 0.8 / 0.5 releasesndk 0.8 and ndk-sys 0.5 releases
Co-authored-by: Robert Bragg <robert@sixbynine.org>
rib
changed the title
ndk 0.8 and ndk-sys 0.5 releasesndk 0.8, ndk-sys 0.5 and android-activity 0.5 releases
Depends on #3126, rust-mobile/android-activity#128
CC @notgull, @kchibisov