-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Key, KeyCode enums #3143
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
19a3e4d
examples/ime, web: prefer use of logical_key
dhardy c5691ed
Split enum KeyCode into PhysicalKey, KeyCode
dhardy 1968f61
Add validation notes on previous commit
dhardy 3e87fe2
Add some From impls for NativeKey, PhysicalKey, Key
dhardy a4077a9
Fixes for KeyCode / PhysicalKey split
dhardy 44832ea
Add some PartialEq impls for NativeKey, Key, etc.
dhardy 8610913
Split enum Key into Key, Action
dhardy c01a81e
Rename Key::Action -> Key::Named, enum Action -> NamedKey
dhardy 9e07381
tests/serde_objects.rs: add NamedKey
dhardy 4fe1b1d
Remove TODO (unnecessary validation)
dhardy 4a7fb76
Merge branch 'master' into key
kchibisov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notgull could you check this please? (Also 52 lines below.)