Don't change the internal canvas size #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would suggest to check glutin as well. |
|
I don't think |
|
Ah, sorry, I for whatever reason thought that it was about macOS. |
This was referenced Jun 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2733, gfx-rs/wgpu#3620 and gfx-rs/wgpu#3690 for more information.
This is a follow-up to gfx-rs/wgpu#3690. Now renderer are responsible for changing the internal canvas size. Winit will still continue to adjust the visual size of the canvas.
Both
wgpuandsoftbufferhandle this correctly. Happy to check and make PR's to other crates that come to mind.Fixes #2733.