Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: internal event buffer & wait for xdg configure #255

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

elinorbgr
Copy link
Contributor

This PR does three things:

  • fix Wayland panic with renderer #254 by properly waiting for the configure xdg event from the compositor, this is done by introducing an internal buffer to collect events dispatched internally, while Window::new() may be blocking
  • automatically insert a WindowEvent::Refresh in this internal buffer whenever a window is created, this guarantees the event loop will have something to dispatch when first started, and should solve for good any issue of deadlock of the event loop as previously saw with wayland (without that, the multiwindow example of glutin still deadlocked)
  • update the wayland_window dependency, which provides a better handling of said configure event

@tomaka
Copy link
Contributor

tomaka commented Aug 31, 2017

Triage. I guess there's no reason not to merge this.

@tomaka tomaka merged commit 1b22e39 into rust-windowing:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Wayland panic with renderer
2 participants