Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed once_cell usage where possible now that Mutex::new and RwLock… #2460

Closed
wants to merge 1 commit into from

Conversation

vahanbgs
Copy link

@vahanbgs vahanbgs commented Sep 2, 2022

…:new are const fns

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@vahanbgs
Copy link
Author

vahanbgs commented Sep 2, 2022

Requires Rust 1.63 to compile, that's why CI checks are failing

@madsmtm
Copy link
Member

madsmtm commented Sep 2, 2022

Yeah, see #2453 for a bit of discussion.

In short, I expect that we'll first be able to include in around ~6 months when distros have caught up, so some time around February. Thanks though!

@kchibisov
Copy link
Member

There's no intention of using 1.63 in a near future.

@kchibisov kchibisov closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants