Improve IME documentation
#2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
S - docs
kchibisov
approved these changes
Apr 17, 2022
msiglreith
reviewed
Apr 18, 2022
madsmtm
commented
Apr 18, 2022
| /// // Press "B" key | ||
| /// Ime::Preedit("a b", Some(3), Some(3)) | ||
| /// // Press left arrow key | ||
| /// Ime::Preedit("a b", Some(1), Some(1)) |
There was a problem hiding this comment.
I should note: This part is technically not true, currently our macOS implementation gives Ime::Preedit("a b", Some(3), Some(3)). But it should give Ime::Preedit("a b", Some(1), Some(1)).
There was a problem hiding this comment.
I can ensure you that it'll work like that on Wayland at least, and that's how it should be on macOS as well? If it doesn't work like that it's likely a macOS bug, though, not really a blocking one...
There was a problem hiding this comment.
Yeah, it's a bug, should be possible to fix just has to do some UTF-16 to UTF-8 encoding that I didn't really see how to do easily.
|
@madsmtm I've pushed a commit adding more docs about |
kchibisov
force-pushed
the
composition-event
branch
2 times, most recently
from
86c5257 to
0f30ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2243.
Please correct me on the specifics here, I may very well be wrong on some of this.