Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WINIT_LINK_COLORSYNC #2136

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Jan 5, 2022

It is no longer needed, since #2078 we link to ApplicationServices, which contains the CGDisplayCreateUUIDFromDisplayID symbol in all macOS versions.

  • @Imberflur could I get you to test this with your old docker setup again?
  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@madsmtm madsmtm added DS - macos S - maintenance Repaying technical debt C - waiting on testing Does this PR work? labels Jan 5, 2022
@Imberflur
Copy link
Contributor

@madsmtm no errors on the docker setup

Since rust-windowing#2078 we link to `ApplicationServices`, which contains the `CGDisplayCreateUUIDFromDisplayID` symbol in all versions.
@madsmtm madsmtm merged commit 51bb6b7 into rust-windowing:master Jan 23, 2022
@madsmtm madsmtm deleted the remove-colorsync-hack branch January 23, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on testing Does this PR work? DS - macos S - maintenance Repaying technical debt
Development

Successfully merging this pull request may close these issues.

2 participants