Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Wayland, try to disable server side decorations for none decorations. #2902

Closed
kchibisov opened this issue Jun 23, 2023 · 0 comments · Fixed by #2904
Closed

On Wayland, try to disable server side decorations for none decorations. #2902

kchibisov opened this issue Jun 23, 2023 · 0 comments · Fixed by #2904
Labels
DS - wayland

Comments

@kchibisov
Copy link
Member

The issue is that the true way to disable all the potential decorations is to use client side decorations, however compositor may ignore such requests, so we'd simply need to not enable the protocol manager for the toplevel in the first place.

We can't disable/enable during runtime, really (there's an option to unmap, but it requires special handling, so better to drop the window entirely).
kchibisov added a commit to kchibisov/winit that referenced this issue Jun 24, 2023
@kchibisov
On Wayland, handle none decorations
bcc6047 
During the migration some logic wrt `none` decorations was lost along
the way, however we also now try to ask for client side decorations if
the user wants to disable server side decorations.

Fixes rust-windowing#2902.
@kchibisov kchibisov mentioned this issue Jun 24, 2023
Merged
kchibisov added a commit that referenced this issue Jun 25, 2023
@kchibisov
On Wayland, handle none decorations
059abb0 
During the migration some logic wrt `none` decorations was lost along
the way, however we also now try to ask for client side decorations if
the user wants to disable server side decorations.

Fixes #2902.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DS - wayland
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On Wayland, handle none decorations kchibisov/winit
1 participant
@kchibisov