Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict compilation of borrowed handles on Android #117

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Mar 30, 2023

Guards borrowed handles behind either std or not being on Android. Should prevent this from being a breaking change.

Another possible way around this would be to add a borrowed feature.

@Lokathor
Copy link
Contributor

it's smoothest if we just turn this on for everyone without the cargo feature, since we'd only remove the cargo feature later. This way, the only people affected are android builders with no_std (who i suspect are very rare).

@Lokathor Lokathor merged commit cda3912 into master Mar 30, 2023
@notgull notgull deleted the notgull/unbreak-android branch March 30, 2023 18:15
@notgull notgull mentioned this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants