[macos] select compatibility profile if gl version is low #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Needs an entry in the Changelog. |
|
@tomaka done |
|
Also, you should either not bump glutin's version in the Cargo.toml, or adjust the changelog for the publication of 0.12.1 that will happen automatically if you do bump the version. |
|
@tomaka ok, I reverted the version change. Affected parties can just use explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix to #963
When the user (@ozkriff in this case... Ohai!) is not explicit about the profile they need, the code doesn't consider compatibility profile, but it should.
Also contains a version bump for supposed publishing. Not sure how you track release branches/versions? I don't see either branches or tags for latest releases.r? @tomaka