Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openharmony support #1702

Merged
merged 5 commits into from
Sep 22, 2024
Merged

Conversation

richerfu
Copy link
Contributor

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

Add openharmony platform support, now we can build it successfully with XComponent. It doesn't effect any other code, so i think i needn't to add more docs or tests.

And you can find a full example with example. If you want more info, please let me know, thanks !

Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also explicitly set that we depend on raw-window-handle 0.6.2, since the build will break otherwise.

CHANGELOG.md Outdated Show resolved Hide resolved
@richerfu
Copy link
Contributor Author

raw-window-handle

Should i update the raw-window-handle version to 0.6.2? Looks not..

@kchibisov
Copy link
Member

Should i update the raw-window-handle version to 0.6.2? Looks not..

open harmony was added in 0.6.2, so you should explicitly specify 0.6.2

@richerfu
Copy link
Contributor Author

Should i update the raw-window-handle version to 0.6.2? Looks not..

open harmony was added in 0.6.2, so you should explicitly specify 0.6.2

Done

glutin-winit/Cargo.toml Outdated Show resolved Hide resolved
glutin_examples/Cargo.toml Outdated Show resolved Hide resolved
@kchibisov kchibisov merged commit 7e46179 into rust-windowing:master Sep 22, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants