Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error compiling to Android with cargo apk #1307 #1385

Closed
wants to merge 6 commits into from

Conversation

Kaiser1989
Copy link

@Kaiser1989 Kaiser1989 commented Dec 28, 2021

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

This merge request addresses the endless unresolved build errors when trying to compile with cargo apk for android.
#1307

There is an open merge request on winit crate:
rust-windowing/winit#2118

If that request is merged, we can finally resolve this bug. But before merging, we need to adjust the winit version in cargo toml. I just want to created this request to address this also on winit side.

Working examples with both fixes can be found here:
https://github.com/Kaiser1989/rust-android-example
https://github.com/Kaiser1989/game-gl

@cdecompilador
Copy link

Any updates on this?

@MarijnS95
Copy link
Member

Thanks for working on reviving Android support! Unfortunately this PR is only commenting out non-compiling code instead of actively fixing the issue at hand.

#1398 is a first - approved - stab at resolving compiler errors, and I have some work queued up that addresses the remainder of event issues with newer winit, to be submitted after that PR is merged. As such there's no need for this PR anymore, but I hope you'll stick around to test the upcoming changes!

@MarijnS95 MarijnS95 closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants