-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: report line coverage instead of function coverage #171
Conversation
It seems that the raw output of llvm-cov changed at some point, and we ended upcomparing functoin coverage instead of line coverage. Fix this by instead using the new json output, which will hopefully prevent such goofs in the future. Fixes rust-vmm#170 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
82798b5
to
de58af0
Compare
Maybe we could also talk about getting rid about these coverage files altogether and instead using codecov.io at some point? We did that at Firecracker a year ago or so |
Yeah, can you open an issue, so if someone has free cycle can look at it. |
I've opened #172 :) |
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `209c04e` to `1150c47`. - [Commits](rust-vmm/rust-vmm-ci@209c04e...1150c47) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> [SG] Updated coverage score since we fixed its calculation, see rust-vmm/rust-vmm-ci#171 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `209c04e` to `1150c47`. - [Commits](rust-vmm/rust-vmm-ci@209c04e...1150c47) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> [SG] Updated coverage score since we fixed its calculation, see rust-vmm/rust-vmm-ci#171 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `2122417` to `1150c47`. - [Commits](rust-vmm/rust-vmm-ci@2122417...1150c47) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> [SG] Updated coverage score since we fixed its calculation, see rust-vmm/rust-vmm-ci#171 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `2122417` to `1150c47`. - [Commits](rust-vmm/rust-vmm-ci@2122417...1150c47) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> [SG] Updated coverage score since we fixed its calculation, see rust-vmm/rust-vmm-ci#171 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `209c04e` to `1150c47`. - [Commits](rust-vmm/rust-vmm-ci@209c04e...1150c47) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> [SG] Updated coverage score since we fixed its calculation, see rust-vmm/rust-vmm-ci#171 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `209c04e` to `1150c47`. - [Commits](rust-vmm/rust-vmm-ci@209c04e...1150c47) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> [SG] Updated coverage score since we fixed its calculation, see rust-vmm/rust-vmm-ci#171 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
It seems that the raw output of llvm-cov changed at some point, and we ended upcomparing functoin coverage instead of line coverage. Fix this by instead using the new json output, which will hopefully prevent such goofs in the future.
Fixes #170
Signed-off-by: Patrick Roy roypat@amazon.co.uk
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.