Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kvm::new_with_fd_number function #115

Closed
andreeaflorescu opened this issue Sep 22, 2020 · 2 comments · Fixed by #118
Closed

Remove Kvm::new_with_fd_number function #115

andreeaflorescu opened this issue Sep 22, 2020 · 2 comments · Fixed by #118
Assignees
@smortime
Labels
good first issue Good for newcomers

Comments

@andreeaflorescu
Copy link
Member

This function is not needed as we already implement FromRawFd for Kvm.
When deleting it, we should also move the documentation of new_with_fd_number to the from_raw_fd function.

The implementation of Kvm::new needs to be adapted as it was using the new_with_fd_number function.
@andreeaflorescu andreeaflorescu added the good first issue Good for newcomers label Sep 22, 2020
@smortime
Copy link
Contributor

👋 I'll take this issue if no one else has started

@andreeaflorescu
Copy link
Member Author

@smortime I've assigned the issue to you. Lemme know if you need help with anything.

smortime added a commit to smortime/kvm-ioctls that referenced this issue Oct 2, 2020
@smortime
Remove Kvm::new_with_fd_number function
9e9be92 
* replace new_with_fd_number with from_raw_fd
* move documentation to from_raw_fd
* update doc tests

Fixes: rust-vmm#115

Signed-off-by: Schuyler Mortimer <schuymortimer@gmail.com>
@smortime smortime mentioned this issue Oct 2, 2020
Merged
smortime added a commit to smortime/kvm-ioctls that referenced this issue Oct 2, 2020
@smortime
Remove Kvm::new_with_fd_number function
8e2dd3a 
* replace new_with_fd_number with from_raw_fd
* move documentation to from_raw_fd
* update doc tests

Fixes: rust-vmm#115

Signed-off-by: Schuyler Mortimer <schuymortimer@gmail.com>
alxiord pushed a commit that referenced this issue Oct 6, 2020
@smortime @alxiord
Remove Kvm::new_with_fd_number function
aed8f65 
* replace new_with_fd_number with from_raw_fd
* move documentation to from_raw_fd
* update doc tests

Fixes: #115

Signed-off-by: Schuyler Mortimer <schuymortimer@gmail.com>
baciumar pushed a commit to baciumar/kvm-ioctls that referenced this issue Nov 9, 2020
@smortime @baciumar
Remove Kvm::new_with_fd_number function
2e88ffb 
* replace new_with_fd_number with from_raw_fd
* move documentation to from_raw_fd
* update doc tests

Fixes: rust-vmm#115

Signed-off-by: Schuyler Mortimer <schuymortimer@gmail.com>
Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>
baciumar pushed a commit to baciumar/kvm-ioctls that referenced this issue Nov 9, 2020
@smortime @baciumar
Remove Kvm::new_with_fd_number function
d365fa9 
* replace new_with_fd_number with from_raw_fd
* move documentation to from_raw_fd
* update doc tests

Fixes: rust-vmm#115

Signed-off-by: Schuyler Mortimer <schuymortimer@gmail.com>
Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smortime smortime

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Kvm::new_with_fd_number function smortime/kvm-ioctls
2 participants
@andreeaflorescu @smortime