Remove dependency on cargo-lock #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Jul 30, 2024
|
Published to crates.io |
|
@Shnatsel what should be done about this? https://github.com/rustsec/rustsec/blob/465967c/cargo-audit/src/binary_deps.rs#L32 |
|
Ooh dammit. I forgot about that. That's actually required for cargo-audit to ingest this data. The implementation of conversion from this format to cargo-lock format (the one I deleted from this repo) will have to be moved into the rustsec repo. We still need the conversion, but at least that will break the cyclic dependency. Unfortunately I won't be able to help with it today. It is a very hot day here, my brain is fried. |
|
Aha, ok |
tarcieri
added a commit
to rustsec/rustsec
that referenced
this pull request
Jul 30, 2024
These drop the dependency on `cargo-lock` Vendors the code removed in rust-secure-code/cargo-auditable#160 into `binary_deps.rs`
tarcieri
added a commit
to rustsec/rustsec
that referenced
this pull request
Jul 30, 2024
These drop the dependency on `cargo-lock` Vendors the code removed in rust-secure-code/cargo-auditable#160 into `binary_deps.rs`
tarcieri
added a commit
to rustsec/rustsec
that referenced
this pull request
Jul 30, 2024
These drop the dependency on `cargo-lock` Vendors the code removed in rust-secure-code/cargo-auditable#160 into `binary_deps.rs`
tarcieri
added a commit
to rustsec/rustsec
that referenced
this pull request
Jul 30, 2024
These drop the dependency on `cargo-lock` Vendors the code removed in rust-secure-code/cargo-auditable#160 into `binary_deps.rs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the disabled-by-default and not very useful conversion to
Cargo.lockformat. It is supplanted by conversion to CycloneDX anyway.This simplifies the release process for
cargo auditconsiderably, removing the cyclic dependency on this repository.I'm not sure I have bumped the versions correctly across the board - some crates depending on
auditable-serdemay require a bump as well.Supersedes #159