Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly configure CC/CXX if we are cross compiling #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

perillamint
Copy link

@perillamint perillamint commented Dec 18, 2024

Checklist

Thanks for contributing! Please ensure

  • All tests are passing
  • Tests or examples are added, if necessary
  • Add a CHANGELOG.md entryin the Unreleased section under the appropriate heading

Pull Request Description

This PR fixes how rpi-led-matrix-sys package compiles its C/C++ dependency by specifying CC/CXX parameter using cc crate.

At least tested on aarch64-unknown-linux-gnu target. (cross --target aarch64-unknown-linux-gnu)

This fixes #43

@perillamint perillamint changed the title Properly configure CC/CXX Properly configure CC/CXX if we are cross compiling Dec 18, 2024
@TDHolmes TDHolmes self-requested a review December 18, 2024 22:26
@TDHolmes
Copy link

Can you add to the release notes too? Thanks!

@perillamint
Copy link
Author

Done! @TDHolmes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants